Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing argument 'except' to function 'url' in state properties #89

Merged

Conversation

bekepr
Copy link
Contributor

@bekepr bekepr commented Jan 28, 2024

Howdy!

I discovered a missing argument in Volt that exists in Livewire, and I believe it would be valuable to have this feature in Volt as well. The missing argument is 'except,' which is used in the 'url' function for state properties. In Livewire, the 'except' argument is employed to exclude specific values from the URL parameters. You can find more details about this feature here.

This fix is non-disruptive, as the 'except' argument is the last (fourth) parameter of the 'url' function, and it has a default value of 'null':

public function url(?string $as = null, ?bool $history = null, ?bool $keep = null, ?string $except = null): static
{
    return $this->attribute(Url::class, as: $as, history: $history, keep: $keep, except: $except);
}

I appreciate your consideration of this enhancement.

Best regards,
Ádám Mezei

@taylorotwell taylorotwell merged commit f565e39 into livewire:main Jan 30, 2024
13 checks passed
@bekepr bekepr deleted the fix/add-missing-arg-except-url-state branch February 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants